Allow VideoFrame to be included as a module a la Node.js/Browserify/etc#12
Open
JoshuaCWebDeveloper wants to merge 4 commits intoallensarkisyan:masterfrom
Open
Allow VideoFrame to be included as a module a la Node.js/Browserify/etc#12JoshuaCWebDeveloper wants to merge 4 commits intoallensarkisyan:masterfrom
JoshuaCWebDeveloper wants to merge 4 commits intoallensarkisyan:masterfrom
Conversation
Credit to philippede: allensarkisyan#2 (comment)
…dardize indents and newlines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accomplished this by encapsulating the library in a function. This of course required that all the code be indented for readability, which of course caused a whole bunch of whitespace changes. I did manage to isolate all of the whitespace changes to a separate commit however.
Also, this mistakenly includes PR #11 .