This repository was archived by the owner on Jun 3, 2021. It is now read-only.
Open
Conversation
ostowe
approved these changes
Dec 13, 2017
Contributor
ostowe
left a comment
ostowe
left a comment
There was a problem hiding this comment.
💯 address comments before merging, otherwise looks good.
| * [Dist][dist_docs] - General information on the distribution (build) directory. | ||
|
|
||
| <!-- External links --> | ||
| [webpack_home]: https://webpack.js.org/ |
Contributor
There was a problem hiding this comment.
this is awesome, had no idea you could do this!
| @@ -1,3 +0,0 @@ | |||
| # Distribution directory | |||
Contributor
There was a problem hiding this comment.
Add this info to CONTRIBUTING.md instead if it isn't already in there
| @@ -1,3 +0,0 @@ | |||
| #!/usr/bin/env node | |||
|
|
|||
| require('./cli'); | |||
Contributor
There was a problem hiding this comment.
Pretty sure we need to keep this actually, forgot about that. CLI won't work without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some links are broken, and others are a bit outdated.
I've updated the broken and outdated links throughout and reformatted them in an effort to make them more easily-updated going forward.