Open
Conversation
added 4 commits
June 19, 2012 13:31
This was out of necessity, but thought should be given for allowing optional arguments to be sent to redis.
Took out the flag parsing so that redis doesn't clobber user defined flags. This is under the philosophy that the redis debug flag will only exist if the user calls flag.Parse(), otherwise the user won't expect their program to accept flags.
Owner
|
Hi, thanks for the heads-up. |
Author
|
@alphazero By the way, this pull request is ready to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new function,
ZRevRangeWithScoresandZIncrby. These were essential for my current use and I will soon expand them to be more generalized and applicable to the project as a whole. Just thought I'd make the pull request now so you know what's happening!