Fix misleading response decoding error#102
Open
AndreMiras wants to merge 1 commit intoalthea-net:masterfrom
Open
Fix misleading response decoding error#102AndreMiras wants to merge 1 commit intoalthea-net:masterfrom
AndreMiras wants to merge 1 commit intoalthea-net:masterfrom
Conversation
For instance in v1.5 a `eth_getBlockByNumber` call that didn't contain
the `totalDifficulty` field would fail with:
```
BadResponse("Size Limit 2961844000 Web3 Error Json deserialize error:
data did not match any variant of untagged enum ResponseData...")
```
While in fact it has nothing to do with the size limit.
After this change the error would be:
```
BadResponse("Failed to process response: Json deserialize error:
data did not match any variant of untagged enum ResponseData...")
```
If the error ends up being buffer size limit related, the message is
still explicit enough:
```
BadResponse("Failed to process response:
Error that occur during reading payload: payload reached size limit")
```
Also refs althea-net/web30#17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For instance in v1.5 a
eth_getBlockByNumbercall that didn't contain thetotalDifficultyfield would fail with:While in fact it has nothing to do with the size limit. After this change the error would be:
If the error ends up being buffer size limit related, the message is still explicit enough:
Also refs althea-net/web30#17