Address PR review feedback: spelling fixes, test coverage, and non-consuming TryInto#33
Closed
Copilot wants to merge 6 commits intojkilpatr/txid-returnsfrom
Closed
Address PR review feedback: spelling fixes, test coverage, and non-consuming TryInto#33Copilot wants to merge 6 commits intojkilpatr/txid-returnsfrom
Copilot wants to merge 6 commits intojkilpatr/txid-returnsfrom
Conversation
These conversions are useful, but should maybe be explicit functions rather than implicit conversions so that we can educate the user as to how it's a bad idea in some situations.
This is easiser to use than the change prefix function in some contexts
By adding a txid to some error cases we can allow the caller to follow the signed transaction even if the intial publishing call fails or times out.
The one thing of note here is that althea_proto was rolled back because everything in the 10 series is currently yanked.
…TryInto implementation Co-authored-by: jkilpatr <19688153+jkilpatr@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add quality of life features and transaction ID handling
Address PR review feedback: spelling fixes, test coverage, and non-consuming TryInto
Jan 20, 2026
b13bf44 to
083285b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from PR #32 to improve code quality and API ergonomics.
Spelling corrections:
retured→returned,therfore→therefore,retieve→retrieveAPI improvement:
TryInto<EthAddress>to implement for&Addressinstead ofAddress, preventing ownership transfer:Test coverage:
test_get_txhashto verify SHA256 hash computationtest_trait_conversionsforTryInto<EthAddress>andFrom<EthAddress>roundtriptest_re_prefixto validate prefix changes preserve underlying bytes✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.