Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
a114059
Add RootPair() and serialization routines to userns idmap
henry118 Nov 13, 2024
168ec21
Update idmapped mount to support multiple uid/gid mappings
henry118 Nov 13, 2024
8a030d6
Update overlay snapshotter to support multiple uid/gid mappings
henry118 Nov 13, 2024
8bbfb65
Update snapshotter opts to support multiple uid/gid mapping entries
henry118 Nov 13, 2024
ec231cd
Update ctr to support remapper labels with multiple uid/gid mapping e…
henry118 Nov 13, 2024
ff0d99e
Add multiple uid/gid mapping test cases to integration tests
henry118 Nov 13, 2024
47c4dba
Unify default transport in docker resolver
djdongjin Dec 16, 2024
1e3d10d
Make ovl idmap mounts read-only
mbaynton Oct 31, 2024
9fc711a
Clarify Go client API guidance
austinvazquez Dec 4, 2024
58bd48e
add some doc for shim reap orphan process
ningmingxiao Mar 27, 2024
651ab7a
Merge pull request #11093 from austinvazquez/fix-go-api-docs
dmcgowan Jan 10, 2025
ccb4c74
Merge pull request #11167 from djdongjin/unify-resolver-transport
dmcgowan Jan 10, 2025
ffbe1b5
Use a order-only-prerequisite for mandir creation
parona-source Dec 10, 2024
b7a117b
Fix fuzz integration tests
djdongjin Jan 11, 2025
6019bcd
move FuzzContainerdImport to go native fuzz
djdongjin Jan 11, 2025
fb44e37
Remove confusing warning in cri runtime config migration
djdongjin Jan 9, 2025
c73c8e5
Introduce EROFS differ
hsiangkao Sep 3, 2024
2486d54
Introduce EROFS Snapshotter
hsiangkao Sep 18, 2024
fd4caef
Add EROFS snapshotter documentation
hsiangkao Sep 19, 2024
2f15d65
Add tests for EROFS snapshotter
hsiangkao Dec 17, 2024
da3d55a
Merge pull request #10980 from djdongjin/improve-cri-runtime-config-m…
AkihiroSuda Jan 13, 2025
6148dbd
Update platforms to latest rc
dmcgowan Jan 13, 2025
0b117a5
Merge pull request #11257 from dmcgowan/update-platforms
dmcgowan Jan 13, 2025
f12042a
Merge pull request #11132 from parona-source/mandir-order
samuelkarp Jan 14, 2025
b49df6a
move FuzzCRIServer to go native fuzz
djdongjin Jan 11, 2025
740c5d4
docs: fix some function names in comment
luchenhan Jan 14, 2025
e20f7f4
Move CDI device spec out of the OCI package
dmcgowan Jan 14, 2025
bdc847f
Remove deprecated WithCDIDevices in oci spec opts
dmcgowan Jan 14, 2025
b87d67f
Merge pull request #11261 from luchenhan/main
samuelkarp Jan 14, 2025
04bac22
Merge pull request #11262 from dmcgowan/fix-cdi-oci-opt
AkihiroSuda Jan 14, 2025
d44d761
Merge pull request #11249 from djdongjin/fix-fuzz-integration-test
samuelkarp Jan 14, 2025
432d32c
Merge pull request #10002 from ningmingxiao/shim_doc
fuweid Jan 14, 2025
c6edc62
Merge pull request #10955 from mbaynton/userns-ovl-followup
fuweid Jan 14, 2025
04f9e30
log: avoid using unsupported field by logrus
zouyee Jan 15, 2025
97119cc
Merge pull request #11251 from djdongjin/move-fuzz-to-go-native-2
kzys Jan 15, 2025
2ab62ac
Merge pull request #11148 from zouyee/cmd
Jan 16, 2025
98af40b
Merge pull request #10722 from henry118/uidmap2
estesp Jan 17, 2025
157faf6
update to go1.23.5 / go1.22.11
akhilerm Jan 18, 2025
460e5a2
build(deps): bump google.golang.org/protobuf from 1.36.1 to 1.36.3
dependabot[bot] Jan 20, 2025
19c546c
build(deps): bump github.com/tchap/go-patricia/v2 from 2.3.1 to 2.3.2
dependabot[bot] Jan 20, 2025
36d3888
build(deps): bump actions/upload-artifact from 4.4.3 to 4.6.0
dependabot[bot] Jan 20, 2025
f572a6d
build(deps): bump lycheeverse/lychee-action from 2.1.0 to 2.2.0
dependabot[bot] Jan 20, 2025
22e7772
build(deps): bump github/codeql-action from 3.27.9 to 3.28.1
dependabot[bot] Jan 20, 2025
4b77d4e
build(deps): bump softprops/action-gh-release from 2.2.0 to 2.2.1
dependabot[bot] Jan 20, 2025
53d6f34
build(deps): bump golangci/golangci-lint-action from 6.1.1 to 6.2.0
dependabot[bot] Jan 20, 2025
d1e5120
Merge pull request #11291 from containerd/dependabot/github_actions/g…
estesp Jan 21, 2025
2a4f369
Merge pull request #11290 from containerd/dependabot/github_actions/g…
estesp Jan 21, 2025
43ffaa1
Merge pull request #11289 from containerd/dependabot/github_actions/s…
estesp Jan 21, 2025
d6ecb6d
Merge pull request #11288 from containerd/dependabot/github_actions/a…
estesp Jan 21, 2025
39b872d
Merge pull request #11282 from containerd/dependabot/go_modules/googl…
AkihiroSuda Jan 21, 2025
69e82f9
build(deps): bump the otel group across 1 directory with 8 updates
dependabot[bot] Jan 21, 2025
a6dc990
client: add WithExtraDialOpts option
thaJeztah Jan 17, 2025
10bfd5f
Merge pull request #11276 from thaJeztah/client_WithExtraDialOpts
estesp Jan 21, 2025
e0e61b6
Merge pull request #11287 from containerd/dependabot/github_actions/l…
estesp Jan 21, 2025
886d971
Update LTS definition and support horizon
dmcgowan Jan 17, 2025
c8df37f
Merge pull request #11277 from akhilerm/go-1.23.5
AkihiroSuda Jan 22, 2025
306c47f
Merge pull request #10033 from ambarve/cimfs_layer_refactor
fuweid Jan 22, 2025
1f85dfe
Merge pull request #11283 from containerd/dependabot/go_modules/githu…
estesp Jan 22, 2025
5f238fa
Update to time based releases
dmcgowan Jan 18, 2025
6d1f6e7
Update upgrade section
dmcgowan Jan 22, 2025
8efbc01
Merge pull request #11286 from containerd/dependabot/go_modules/otel-…
Jan 25, 2025
48d0910
build(deps): bump github/codeql-action from 3.28.1 to 3.28.6
dependabot[bot] Jan 27, 2025
5752397
build(deps): bump actions/stale from 9.0.0 to 9.1.0
dependabot[bot] Jan 27, 2025
0c986c3
build(deps): bump actions/attest-build-provenance from 2.1.0 to 2.2.0
dependabot[bot] Jan 27, 2025
2633eb5
Merge pull request #11316 from containerd/dependabot/github_actions/a…
dmcgowan Jan 31, 2025
168c49e
Fix state/root bug in shim sandbox controller
djdongjin Jan 28, 2025
2eb0aa6
nri: make OCI spec available on StopPodSandbox
aojea Feb 3, 2025
ee73f33
Merge pull request #11317 from containerd/dependabot/github_actions/a…
estesp Feb 3, 2025
2fda52e
Merge pull request #11315 from containerd/dependabot/github_actions/g…
estesp Feb 3, 2025
565b50d
build(deps): bump google-github-actions/auth from 2.1.7 to 2.1.8
dependabot[bot] Feb 4, 2025
841ab36
build(deps): bump github/codeql-action from 3.28.6 to 3.28.8
dependabot[bot] Feb 4, 2025
b65f387
build(deps): bump google-github-actions/upload-cloud-storage
dependabot[bot] Feb 4, 2025
06329b2
Merge pull request #11321 from djdongjin/fix-root-state-shim-controller
Feb 4, 2025
d71e0e3
Merge pull request #11333 from containerd/dependabot/github_actions/g…
Feb 5, 2025
befec68
Merge pull request #11334 from containerd/dependabot/github_actions/g…
Feb 5, 2025
ef5118a
Merge pull request #11332 from containerd/dependabot/github_actions/g…
Feb 5, 2025
e0c8298
Merge pull request #11331 from aojea/nri_stopPodSandbox
Feb 5, 2025
dbce6a6
Merge pull request #11294 from dmcgowan/new-release-schedule
dmcgowan Feb 5, 2025
59c8cf6
Merge pull request #10705 from erofs/erofs-snapshotter
dmcgowan Feb 5, 2025
a1c5400
Support for importing layers in the block CIM format.
ambarve Feb 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"features": {
"ghcr.io/devcontainers/features/docker-in-docker:2": {},
"ghcr.io/devcontainers/features/go:1": {
"version": "1.23.4"
"version": "1.23.5"
}
},

Expand Down
2 changes: 1 addition & 1 deletion .github/actions/install-go/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: "Reusable action to install Go, so there is one place to bump Go ve
inputs:
go-version:
required: true
default: "1.23.4"
default: "1.23.5"
description: "Go version to install"

runs:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/api-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
name: API Release

env:
GO_VERSION: "1.23.4"
GO_VERSION: "1.23.5"

permissions: # added using https://github.com/step-security/secure-workflows
contents: read
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
working-directory: src/github.com/containerd/containerd

- name: Save release notes
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
with:
name: containerd-release-notes
path: src/github.com/containerd/containerd/release-notes.md
Expand All @@ -69,7 +69,7 @@ jobs:
with:
path: builds
- name: Create Release
uses: softprops/action-gh-release@7b4da11513bf3f43f9999e90eabced41ab8bb048 # v2.2.0
uses: softprops/action-gh-release@c95fe1489396fe8a9eb87c0abf8aa5b2ef267fda # v2.2.1
with:
token: ${{ secrets.GITHUB_TOKEN }}
fail_on_unmatched_files: true
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: ./.github/actions/install-go
- uses: golangci/golangci-lint-action@971e284b6050e8a5849b72094c50ab08da042db8 # v6.1.1
- uses: golangci/golangci-lint-action@ec5d18412c0aeab7936cb16880d708ba2a64e1ae # v6.2.0
with:
version: v1.60.3
skip-cache: true
Expand Down Expand Up @@ -191,7 +191,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-22.04, ubuntu-24.04, arm64-8core-32gb, macos-13, windows-2019, windows-2022]
go-version: ["1.22.10", "1.23.4"]
go-version: ["1.22.11", "1.23.5"]
exclude:
- os: ${{ github.repository != 'containerd/containerd' && 'arm64-8core-32gb' }}
steps:
Expand Down Expand Up @@ -367,7 +367,7 @@ jobs:
}
critest.exe --runtime-endpoint=npipe://.//pipe//containerd-containerd --test-images-file='${{env.CRI_TEST_IMAGES}}' --report-dir='${{github.workspace}}/critestreport' $skip

- uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
- uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
if: always()
with:
name: TestResults ${{ matrix.os }} ${{ matrix.cgroup_driver }}
Expand Down Expand Up @@ -514,7 +514,7 @@ jobs:
sudo lsmod
sudo dmesg -T -f kern

- uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
- uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
if: always()
with:
name: TestResults ${{ matrix.runtime }} ${{matrix.runc}} ${{ matrix.os }} ${{ matrix.cgroup_driver }}
Expand Down Expand Up @@ -686,7 +686,7 @@ jobs:
if: always()
- run: script/test/test2annotation.sh *-gotest.json
if: always()
- uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
- uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
if: always()
with:
name: TestResults MacOS
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@df409f7d9260372bd5f19e5b04e83cb3c43714ae # v3.27.9
uses: github/codeql-action/init@dd746615b3b9d728a6a37ca2045b68ca76d4841a # v3.28.8
# Override language selection by uncommenting this and choosing your languages
# with:
# languages: go, javascript, csharp, python, cpp, java
Expand All @@ -46,4 +46,4 @@ jobs:
make

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@df409f7d9260372bd5f19e5b04e83cb3c43714ae # v3.27.9
uses: github/codeql-action/analyze@dd746615b3b9d728a6a37ca2045b68ca76d4841a # v3.28.8
2 changes: 1 addition & 1 deletion .github/workflows/fuzz.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
language: go
continue-on-error: true
- name: Upload Crash
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
if: failure() && steps.build.outcome == 'success'
with:
name: artifacts
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/links.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

- uses: lycheeverse/lychee-action@f81112d0d2814ded911bd23e3beaa9dda9093915 # v2.1.0
- uses: lycheeverse/lychee-action@f796c8b7d468feb9b8c0a46da3fac0af6874d374 # v2.2.0
with:
# Fail action on broken links
fail: true
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,31 +99,31 @@ jobs:
#

- name: Upload artifacts (linux_amd64)
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
with:
name: linux_amd64
path: src/github.com/containerd/containerd/bin_amd64

- name: Upload artifacts (linux_arm64)
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
with:
name: linux_arm64
path: src/github.com/containerd/containerd/bin_arm64

- name: Upload artifacts (linux_s390x)
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
with:
name: linux_s390x
path: src/github.com/containerd/containerd/bin_s390x

- name: Upload artifacts (linux_ppc64le)
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
with:
name: linux_ppc64le
path: src/github.com/containerd/containerd/bin_ppc64le

- name: Upload artifacts (linux_riscv64)
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
with:
name: linux_riscv64
path: src/github.com/containerd/containerd/bin_riscv64
Expand Down Expand Up @@ -158,7 +158,7 @@ jobs:
make binaries

- name: Upload artifacts (windows_amd64)
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
with:
name: windows_amd64
path: src/github.com/containerd/containerd/bin/
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
name: Release

env:
GO_VERSION: "1.23.4"
GO_VERSION: "1.23.5"

permissions: # added using https://github.com/step-security/secure-workflows
contents: read
Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
working-directory: src/github.com/containerd/containerd

- name: Save release notes
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
with:
name: containerd-release-notes
path: src/github.com/containerd/containerd/release-notes.md
Expand Down Expand Up @@ -127,7 +127,7 @@ jobs:
env:
PLATFORM: ${{ matrix.dockerfile-platform }}
- name: Save Artifacts
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
with:
name: release-tars-${{env.PLATFORM_CLEAN}}
path: src/github.com/containerd/containerd/releases/*.tar.gz*
Expand All @@ -149,13 +149,13 @@ jobs:
path: builds
- name: Attest Artifacts
id: attest
uses: actions/attest-build-provenance@7668571508540a607bdfd90a87a560489fe372eb # v2.1.0
uses: actions/attest-build-provenance@520d128f165991a6c774bcb264f323e3d70747f4 # v2.2.0
with:
subject-path: ./builds/release-tars-**/*.tar.gz
- name: Rename attestation artifact
run: mv ${{ steps.attest.outputs.bundle-path }} containerd-${{ needs.check.outputs.stringver }}-attestation.intoto.jsonl
- name: Create Release
uses: softprops/action-gh-release@7b4da11513bf3f43f9999e90eabced41ab8bb048 # v2.2.0
uses: softprops/action-gh-release@c95fe1489396fe8a9eb87c0abf8aa5b2ef267fda # v2.2.1
with:
token: ${{ secrets.GITHUB_TOKEN }}
fail_on_unmatched_files: true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/scorecards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@ jobs:
# Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
# format to the repository Actions tab.
- name: "Upload artifact"
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # tag=v4.4.3
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # tag=v4.6.0
with:
name: SARIF file
path: results.sarif
retention-days: 5

# Upload the results to GitHub's code scanning dashboard.
- name: "Upload to code-scanning"
uses: github/codeql-action/upload-sarif@df409f7d9260372bd5f19e5b04e83cb3c43714ae # tag=v3.27.9
uses: github/codeql-action/upload-sarif@dd746615b3b9d728a6a37ca2045b68ca76d4841a # tag=v3.28.8
with:
sarif_file: results.sarif
2 changes: 1 addition & 1 deletion .github/workflows/stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
pull-requests: write

steps:
- uses: actions/stale@28ca1036281a5e5922ead5184a1bbf96e5fc984e # v9.0.0
- uses: actions/stale@5bef64f19d7facfb25b37b414482c7164d639639 # v9.1.0
# All stale bot options: https://github.com/actions/stale#all-options
with:
# Idle number of days before marking issues/PRs stale
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/windows-hyperv-periodic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -306,22 +306,22 @@ jobs:
echo 'GCP_WORKLOAD_IDENTITY_PROVIDER=${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}' >> $GITHUB_OUTPUT

- name: AuthGcp
uses: google-github-actions/auth@6fc4af4b145ae7821d527454aa9bd537d1f2dc5f # v2.1.7
uses: google-github-actions/auth@71f986410dfbc7added4569d411d040a91dc6935 # v2.1.8
if: steps.AssignGcpCreds.outputs.GCP_SERVICE_ACCOUNT && steps.AssignGcpCreds.outputs.GCP_WORKLOAD_IDENTITY_PROVIDER
with:
service_account: ${{ secrets.GCP_SERVICE_ACCOUNT }}
workload_identity_provider: ${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}

- name: UploadJobReport
uses: google-github-actions/upload-cloud-storage@386ab77f37fdf51c0e38b3d229fad286861cc0d0 # v2.2.1
uses: google-github-actions/upload-cloud-storage@7c6e11cb7291594c5dfe0bc1dd9cd905e31e600c # v2.2.2
if: steps.AssignGcpCreds.outputs.GCP_SERVICE_ACCOUNT && steps.AssignGcpCreds.outputs.GCP_WORKLOAD_IDENTITY_PROVIDER
with:
path: ${{ github.workspace }}/latest-build.txt
destination: ${{ matrix.GOOGLE_BUCKET }}
parent: false

- name: UploadLogsDir
uses: google-github-actions/upload-cloud-storage@386ab77f37fdf51c0e38b3d229fad286861cc0d0 # v2.2.1
uses: google-github-actions/upload-cloud-storage@7c6e11cb7291594c5dfe0bc1dd9cd905e31e600c # v2.2.2
if: steps.AssignGcpCreds.outputs.GCP_SERVICE_ACCOUNT && steps.AssignGcpCreds.outputs.GCP_WORKLOAD_IDENTITY_PROVIDER
with:
path: ${{ env.LOGS_DIR }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/windows-periodic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -256,22 +256,22 @@ jobs:
echo 'GCP_WORKLOAD_IDENTITY_PROVIDER=${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}' >> $GITHUB_OUTPUT

- name: AuthGcp
uses: google-github-actions/auth@6fc4af4b145ae7821d527454aa9bd537d1f2dc5f # v2.1.7
uses: google-github-actions/auth@71f986410dfbc7added4569d411d040a91dc6935 # v2.1.8
if: steps.AssignGcpCreds.outputs.GCP_SERVICE_ACCOUNT && steps.AssignGcpCreds.outputs.GCP_WORKLOAD_IDENTITY_PROVIDER
with:
service_account: ${{ secrets.GCP_SERVICE_ACCOUNT }}
workload_identity_provider: ${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}

- name: UploadJobReport
uses: google-github-actions/upload-cloud-storage@386ab77f37fdf51c0e38b3d229fad286861cc0d0 # v2.2.1
uses: google-github-actions/upload-cloud-storage@7c6e11cb7291594c5dfe0bc1dd9cd905e31e600c # v2.2.2
if: steps.AssignGcpCreds.outputs.GCP_SERVICE_ACCOUNT && steps.AssignGcpCreds.outputs.GCP_WORKLOAD_IDENTITY_PROVIDER
with:
path: ${{ github.workspace }}/latest-build.txt
destination: ${{ matrix.GOOGLE_BUCKET }}
parent: false

- name: UploadLogsDir
uses: google-github-actions/upload-cloud-storage@386ab77f37fdf51c0e38b3d229fad286861cc0d0 # v2.2.1
uses: google-github-actions/upload-cloud-storage@7c6e11cb7291594c5dfe0bc1dd9cd905e31e600c # v2.2.2
if: steps.AssignGcpCreds.outputs.GCP_SERVICE_ACCOUNT && steps.AssignGcpCreds.outputs.GCP_WORKLOAD_IDENTITY_PROVIDER
with:
path: ${{ env.LOGS_DIR }}
Expand Down
8 changes: 4 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ bin/containerd-shim-runc-v2: cmd/containerd-shim-runc-v2 FORCE # set !cgo and om
binaries: $(BINARIES) ## build binaries
@echo "$(WHALE) $@"

man: mandir $(addprefix man/,$(MANPAGES))
man: $(addprefix man/,$(MANPAGES))
@echo "$(WHALE) $@"

mandir:
Expand All @@ -289,15 +289,15 @@ mandir:
# Kept for backwards compatibility
genman: man/containerd.8 man/ctr.8

man/containerd.8: bin/gen-manpages FORCE
man/containerd.8: bin/gen-manpages FORCE | mandir
@echo "$(WHALE) $@"
$< $(@F) $(@D)

man/ctr.8: bin/gen-manpages FORCE
man/ctr.8: bin/gen-manpages FORCE | mandir
@echo "$(WHALE) $@"
$< $(@F) $(@D)

man/%: docs/man/%.md FORCE
man/%: docs/man/%.md FORCE | mandir
@echo "$(WHALE) $@"
go-md2man -in "$<" -out "$@"

Expand Down
Loading