Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds Nix support for PHPGGC so it can be built/run fully reproducible using Nix without Docker.
flake.nixwith:packages.phpggc/packages.default(nix build .#phpggc)apps.default(nix run .#phpggc -- …)devShells.default(nix develop)package.nixthat packages the repository as a Nix derivation:gadgetchains/,lib/,templates/, etc.) into$out/share/phpggcphpggcwrapper in$out/bin/phpggcthat runs via Nix’s PHP withphar.readonly=0and changes the cwd into the installedshare/dir so relative includes workshell.nixdev environment roughly mirroring the Dockerfile tooling:php,composer,curl,python3,python3Packages.rich, plus the packagedphpggcWhy:
How to use / test:
From the repo root:
nix build .#phpggcnix run .#phpggc -- -lnix run .#phpggc -- <chain> [args…]nix developnix-shellNotes:
-d phar.readonly=0to match theDockerfilebehavior and support PHAR payload generation when requested.phpggcscript is stored under$out/share/phpggc(invoked via the wrapper), so it doesn't rely on the source checkout layout at runtime.Files added:
flake.nixshell.nixpackage.nixflake.lock