Skip to content

Conversation

@ameshkov
Copy link
Owner

No description provided.

@ameshkov ameshkov requested a review from Copilot October 13, 2025 10:10
@ameshkov ameshkov self-assigned this Oct 13, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Oblivious HTTP (OHTTP) support to gocurl, allowing users to send encrypted HTTP requests through an OHTTP gateway that provides enhanced privacy by hiding client identity from the target server.

Key changes:

  • Added new command-line flags --ohttp-gateway-url and --ohttp-keys-url for OHTTP configuration
  • Implemented oblivious HTTP transport layer with encryption/decryption capabilities
  • Fixed logging output to use configurable writers instead of hardcoded stderr

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/config/options.go Added OHTTP configuration options with gateway and keys URL fields
internal/config/config.go Added OHTTP URL parsing and validation logic requiring both options together
internal/client/transport.go Added conditional routing to OHTTP transport when OHTTP URLs are configured
internal/client/ohttp.go Implemented complete OHTTP transport with encryption, gateway communication, and decryption
internal/output/output.go Fixed logging methods to use configurable log writer instead of hardcoded stderr
internal/cmd/cmd_test.go Added comprehensive test coverage for OHTTP functionality and proxy integration
go.mod Added ohttp-go library dependency
README.md Added comprehensive OHTTP documentation with usage examples
CHANGELOG.md Added changelog entry for new OHTTP features

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

ameshkov and others added 3 commits October 13, 2025 13:20
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ameshkov ameshkov requested a review from Copilot October 13, 2025 11:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ameshkov ameshkov merged commit 6dbf70d into master Oct 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants