Fix parseGitHostURL appending /api/v4/ to non-GitLab services#202
Merged
amitsaha merged 1 commit intoamitsaha:masterfrom Feb 21, 2026
Merged
Fix parseGitHostURL appending /api/v4/ to non-GitLab services#202amitsaha merged 1 commit intoamitsaha:masterfrom
amitsaha merged 1 commit intoamitsaha:masterfrom
Conversation
Only GitLab requires /api/v4/ appended to custom host URLs. Previously this was appended for all services (with a special case to skip Forgejo), which broke GitHub Enterprise and Bitbucket custom host URLs. Fixes amitsaha#195
Owner
|
thanks @rdowavic 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseGitHostURLwas appending/api/v4/to custom host URLs for all services, but this is only correct for GitLab/api/v3/, handled by the go-github library itself) and Bitbucket custom hosts/api/v4/for GitLab, return the plain URL for everything elseTest plan
go test ./...)TestNewClientto assert GitHub Enterprise gets the plain URL (not/api/v4/)/api/v4/is appendedFixes #195