Fix Forgejo clone authentication and SSH URL support#204
Open
rdowavic wants to merge 1 commit intoamitsaha:masterfrom
Open
Fix Forgejo clone authentication and SSH URL support#204rdowavic wants to merge 1 commit intoamitsaha:masterfrom
rdowavic wants to merge 1 commit intoamitsaha:masterfrom
Conversation
- Add Forgejo case to getUsername() in helpers.go so credentials are embedded in HTTPS clone URLs for private repos - Set gitHostToken in newForgejoClient() so the token is available for HTTPS cloning - Use getCloneURL() in forgejo.go instead of hardcoding repo.CloneURL, so SSH URLs are used when -use-https-clone is not set - Fix test mock data to include both clone_url and ssh_url fields Fixes amitsaha#193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getUsername()so HTTPS clone URLs include credentials for private reposgitHostTokeninnewForgejoClient()so the token is available during HTTPS cloninggetCloneURL()inforgejo.goinstead of hardcodingrepo.CloneURL, so SSH URLs are used when-use-https-cloneis not setclone_urlandssh_urlfieldsFixes #193
Test plan
go test ./...passes-use-https-clone-use-https-cloneis not set