Remove unused parameters from repository functions#207
Open
rdowavic wants to merge 1 commit intoamitsaha:masterfrom
Open
Remove unused parameters from repository functions#207rdowavic wants to merge 1 commit intoamitsaha:masterfrom
rdowavic wants to merge 1 commit intoamitsaha:masterfrom
Conversation
Each get*Repositories function was receiving all 8 parameters from
getRepositories, even though most were unused. For example,
getGitlabRepositories received githubRepoType, githubNamespaceWhitelist,
ignoreFork, and forgejoRepoType — none of which it uses.
Now each function only accepts what it needs and uses typed client
pointers instead of interface{}, with type assertions and the nil
client check moved to the getRepositories dispatcher.
rdowavic
force-pushed
the
feat/remove-unused-params-from-repo-functions
branch
from
7aeefa5 to
86b0ca5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get*Repositoriesfunction was receiving all 8 parameters fromgetRepositories, even though most were unused (e.g.,getGitlabRepositoriesreceivedgithubRepoType,githubNamespaceWhitelist,ignoreFork, andforgejoRepoType— none of which it uses)*github.Client) instead ofinterface{}, with type assertions moved to thegetRepositoriesdispatcherContributes to #67
Test plan
go build ./...compilesgo test ./...passes