Skip to content

Conversation

@FabricioFFC
Copy link

Summary

Prevents trim is not a function exception when user_id/device_id is not a string.

@macroscopeapp
Copy link

macroscopeapp bot commented Jan 28, 2026

Prevent trim-is-not-a-function exceptions by coercing and trimming non-string identifiers in Exposure.canonicalize in exposure.ts

Update Exposure.canonicalize to coerce user_id, device_id, and variant.key with String(...) before trimming; add tests verifying numeric user_id and device_id do not throw in exposure-filter.test.ts.

📍Where to Start

Start with Exposure.canonicalize in exposure.ts.


Macroscope summarized 390a025.

@FabricioFFC FabricioFFC deleted the GLACIER-8143 branch January 28, 2026 18:49
@FabricioFFC FabricioFFC changed the title [GLACIER-8143] prevents trim is not a function exception prevents trim is not a function exception Jan 28, 2026
@FabricioFFC FabricioFFC restored the GLACIER-8143 branch January 28, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant