Merged
Conversation
pkitazos
requested changes
Feb 5, 2026
Collaborator
pkitazos
left a comment
pkitazos
left a comment
There was a problem hiding this comment.
As far as I can tell this seems to be faithful to the diagram. I just have a couple nits and some questions. Once you address those, feel free to merge.
JakeTrevor
commented
Feb 5, 2026
Collaborator
Author
JakeTrevor
left a comment
JakeTrevor
left a comment
There was a problem hiding this comment.
That's all the comments addressed now. @pkitazos can I request a re-review? We can merge this if you approve.
The migrations now included mean you should be able to do prisma migrate dev or prisma migrate deploy to bring ur copy of the db up to spec.
pkitazos
approved these changes
Feb 6, 2026
Collaborator
pkitazos
left a comment
pkitazos
left a comment
There was a problem hiding this comment.
Looks good.
Just so I'm clear, we're not adding markerType right now?
Collaborator
Author
|
Correct - for now no marker type I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite an important one this time.
We planned out the data model in an excalidraw. A picture of the relevant bit is here:
I think I've gotten the data model to match, but a second pair of eyes on it would be much appreciated.