Skip to content

Fix lint and type errors relating to data model change#358

Merged
JakeTrevor merged 4 commits intojacobtrevor234/amp-231-update-data-modelfrom
jacobtrevor234/amp-231-update-data-model-fix
Feb 5, 2026
Merged

Fix lint and type errors relating to data model change#358
JakeTrevor merged 4 commits intojacobtrevor234/amp-231-update-data-modelfrom
jacobtrevor234/amp-231-update-data-model-fix

Conversation

@JakeTrevor
Copy link
Collaborator

No description provided.

@JakeTrevor JakeTrevor requested a review from pkitazos February 5, 2026 15:36
@JakeTrevor JakeTrevor self-assigned this Feb 5, 2026
Copy link
Collaborator

@pkitazos pkitazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

(typeof ProjectAllocationStatus)[keyof typeof ProjectAllocationStatus];

// Consider simplifying as below:
// export type ProjectAllocationStatus2 = keyof typeof ProjectAllocationStatus;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this is nicer

@JakeTrevor JakeTrevor merged commit 260991e into jacobtrevor234/amp-231-update-data-model Feb 5, 2026
7 checks passed
@JakeTrevor JakeTrevor deleted the jacobtrevor234/amp-231-update-data-model-fix branch February 5, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants