Skip to content

TM - Formulario terapéutico: nuevo esquema y api #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Fabio-Ramirez wants to merge 2 commits into
base: master
Choose a base branch
from
Open

TM - Formulario terapéutico: nuevo esquema y api #2146

Fabio-Ramirez wants to merge 2 commits into from

Conversation

@Fabio-Ramirez
Copy link
Contributor

@Fabio-Ramirez Fabio-Ramirez commented Nov 13, 2025 •
edited
Loading

Requerimiento

https://proyectos.andes.gob.ar/browse/TM-42

Funcionalidad desarrollada

  1. Se cambia schema y routes de FormularioTerapeutico, para transformarlo en resources base.
  2. Se agregan nuevos schemas ftpSistema, ftFuncion y ftpGrupoFarmacologico, con el fin de poder individualizar a futuro.
  3. Directamente se deja el archivo baseFarmacia.json para la ejecucion del scripts, que a su vez va cargando los datos en cada una de las colecciones que salen del punto 2.
  4. Para ejecutar scripts: node jobs/manual.js scripts/importarFormularios.js
  5. Se elimina archivo del controller por ahora innecesario.

UserStories llegó a completarse

  • Si
  • No

Requiere actualizaciones en la base de datos

  • Si: por eso el archivo baseFaramacologico
  • No

@Fabio-Ramirez Fabio-Ramirez requested review from a team as code owners November 13, 2025 19:00
@github-actions github-actions bot added the script Necesidad de aplicar un scripts label Nov 13, 2025
negro89
negro89 reviewed Nov 27, 2025
View reviewed changes
core/tm/schemas/formularioTerapeutico.ts
potencia: String,
unidades: String,
presentacion: String,
atcVia: String,
Copy link
Contributor

@negro89 negro89 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

este atributo es correcto o se coló con algun error de tipeo?

Copy link
Contributor Author

@Fabio-Ramirez Fabio-Ramirez Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compa, el atributo está definido de esta manera porque refleja exactamente el nombre utilizado en la planilla original.

negro89
negro89 reviewed Nov 27, 2025
View reviewed changes
core/tm/schemas/formularioTerapeutico.ts Outdated
type: mongoose.Schema.Types.ObjectId,

export const formularioTerapeuticoSchema = new Schema({
sistema: {
Copy link
Contributor

@negro89 negro89 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acá no deberían ir ftpSistemaSchema, ftpFuncionSchema, ftpGrupoFarmacologicoSchema respectivamente?

Copy link
Contributor Author

@Fabio-Ramirez Fabio-Ramirez Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correguido.

@negro89 negro89 added the En revisión Se está probando label Nov 27, 2025
@Fabio-Ramirez Fabio-Ramirez added changes done and removed En revisión Se está probando labels Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@negro89 negro89 negro89 left review comments

@agustin1996ra agustin1996ra Awaiting requested review from agustin1996ra agustin1996ra is a code owner automatically assigned from andes/code-review

@AgosLizzi AgosLizzi Awaiting requested review from AgosLizzi AgosLizzi is a code owner automatically assigned from andes/code-review

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

changes done script Necesidad de aplicar un scripts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fabio-Ramirez @negro89