Skip to content

Misc hooks + fixes#8

Open
eli-schwartz wants to merge 4 commits intoandrewgregory:masterfrom
eli-schwartz:master
Open

Misc hooks + fixes#8
eli-schwartz wants to merge 4 commits intoandrewgregory:masterfrom
eli-schwartz:master

Conversation

@eli-schwartz
Copy link

  • A couple hooks I've been playing with:
    • vimdoc.hook
    • gtk-update-icon-cache.hook
  • Based on the trick I used in gtk-update-icon-cache, I've also merged the mkfontdir/mkfontscale OTF/TTF hooks and made them apply to all fonts.
  • update-mime-database should use a relative path, in case people are using an alternative --root.
  • Also do a slightly better glob for install-info files, which also leaves out these pesky .*\.png(\.gz)? files (mainly owned by gnutls on my system). Really? I didn't know texinfo did images... but either way it is a waste of time to try indexing them, so why bother? 😆
  • Add descriptions to the hooks, for eye candy.

@eli-schwartz
Copy link
Author

Good catch, but not all info pages end in *.gz (for example, see Arch's maxima package).

Huh, I didn't realize that actually happens. Apparently the PKGBUILD specifies !zipman.
I guess usr/share/info/*info* would work just as well though.

libalpm chroots into the installation root before running hooks or install scripts; this should not be necessary.

Perhaps I was confused by the fact that install scriptlets always seem to use relative paths when doing the same thing (although now I come to think of it, they sometimes use absolute paths for other things).
If that isn't a requirement, is one or the other an official style preference?

I agree that it would be nice to not have to do these per font type, but I'm not sure these triggers are correct. Not all directories under usr/share/fonts/ contain fonts.

I will happily admit to knowing next to nothing about fonts. 😄 Is there a specific set of directories that do other things and can be excluded? Or maybe just use awk or sed to get the last directory on a file trigger...

@andrewgregory
Copy link
Owner

Huh, I didn't realize that actually happens. Apparently the PKGBUILD specifies !zipman.
I guess usr/share/info/info would work just as well though.

I would use usr/share/info/*.info*

Perhaps I was confused by the fact that install scriptlets always seem to use relative paths when doing the same thing (although now I come to think of it, they sometimes use absolute paths for other things).
If that isn't a requirement, is one or the other an official style preference?

My preference is for absolute paths.

I will happily admit to knowing next to nothing about fonts. 😄 Is there a specific set of directories that do other things and can be excluded? Or maybe just use awk or sed to get the last directory on a file trigger...

I don't know enough about fonts to answer that question, which is why I went with the original conservative approach.

@eli-schwartz eli-schwartz force-pushed the master branch 2 times, most recently from 1f5b1b3 to 71e6805 Compare March 18, 2016 14:31
@eli-schwartz
Copy link
Author

So I've deleted the mkfontdir/mkfontscale changes for now, as well as the unneeded changes to update-mime-database.
I've pushed a new set of install-info hooks.

The mkfontdir/mkfontscale commit is still available at eli-schwartz/pachooks@1f5b1b3 for reference, and I will open an issue for it in case anyone has suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants