Simplify Keys and ResultMap structs #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the pr. I’m currently juggling a few things but I’ll look over it in the coming days. |
Author
|
After looking at some errors, decided to use Keys as originally defined...did find some interesting enhancements in the process though... |
Owner
|
@luisjakon if you have any ideas that differ from the current PR please open a second PR. Thanks for the contributions BTW! |
Author
|
The ideas are somewhat intertwined. While trying to simplify the structs I came across an enhancement to the LoadMany cache retrieval code which I unintentionally embedded onto this PR, but it works. Have a look at the dataloader.LoadMany(...) function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to remove hard dependencies on strings and use these structs a close to bare metal as possible.
It may be also possible to remove dependence on defined methods for internal calls in the future since the new definitions are simple native arrays and maps in go. The benefit here is that downstream consumers can simply choose to use them as such through simple conversions.