Add toggle to connection settings panel for warehouse to disable the … #802
Conversation
…service worker, add disable service worker to connection settings.
| }; | ||
|
|
||
| const onDataLoaded = (data: LoadedData) => { | ||
| if ('serviceWorker' in navigator) { |
There was a problem hiding this comment.
I feel like instead of a manual toggle, this should instead be tied to some logic checking if a remote storage service is used at all? I can't think of a scenario where you could be simultaneously offline and using a remote data store? At least, that's how I had been considering doing something similar to this. Thoughts?
There was a problem hiding this comment.
That seems reasonable. To be honest, I'm not sure what the service worker does and why exactly hosting locally causes problems. Would you still run into this problem if you got a cert for it?
There was a problem hiding this comment.
does this even need to be a separate bool then? or just if useWarehouse is true, unregister the service worker?
There was a problem hiding this comment.
I'm also a little uncertain on how exactly the service worker works, but you probably still want to also check if it is in navigator, but otherwise yeah don't need to have a dedicated option bool for it. I would recommend still creating a logic method somewhere (which to start will just be 'is useWarehouse true')....but there might be other things coming that would also warrant disabling the serviceworker but don't involve that particular boolean.
2 participants
…service worker, add disable service worker to connection settings.