Fix ignoreCallback bug#1
Open
nilbus wants to merge 1 commit intoandyfowler:localstorage-firstfrom
nilbus:localstorage-first
Open
Fix ignoreCallback bug#1nilbus wants to merge 1 commit intoandyfowler:localstorage-firstfrom nilbus:localstorage-first
nilbus wants to merge 1 commit intoandyfowler:localstorage-firstfrom
nilbus:localstorage-first
Conversation
localsync was running callbacks when it was not intended. In ff828fc, backbone.dualstorage.coffee:228 added: options.ignoreCallbacks = false Changing the options object also affects the other callbacks that use options (such as line 202: localsync('clear', model, options)) since multiple callbacks are defined in the same scope using the same options variable. In my case, the localsync('clear', ...) was called with ignoreCallbacks = false. Since clear doesn't return a response, the error callback would get called once for each collection item every time I would fetch on the collection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not using this branch any more, but this fix should probably be useful to you.
localsync was running callbacks when it was not intended.
In ff828fc, backbone.dualstorage.coffee:228 added:
Changing the options object also affects the other callbacks that use options (such as line 202:
localsync('clear', model, options))since multiple callbacks are defined in the same scope using the same options variable. In my case, thelocalsync('clear', ...)was called with ignoreCallbacks = false. Since clear doesn't return a response, the error callback would get called once for each collection item every time I would fetch on the collection.