Open
Conversation
victordmontero
force-pushed
the
dev/victor-test2
branch
from
76c102d to
80c282f
Compare
victordmontero
force-pushed
the
dev/victor-test2
branch
from
80c282f to
c2a7c27
Compare
victordmontero
commented
Jan 20, 2026
Comment on lines
-20
to
-24
| set(SDL2IMAGE_INSTALL OFF) | ||
| set(BUILD_SHARED_LIBS FALSE) | ||
| set(SDL2_DISABLE_INSTALL OFF) | ||
| set(SDL2TTF_VENDORED TRUE) | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Decided to move to fetchSDL cmake module
Comment on lines
-161
to
-233
|
|
||
| #add_executable(${PROJECT_NAME}-sample | ||
| # sample/ignored_main.cpp | ||
| #) | ||
| add_executable(${PROJECT_NAME}-pong-sample | ||
| sample/pong/SimplePong.cpp | ||
| ) | ||
|
|
||
| add_executable(${PROJECT_NAME}-SpaceInvader-sample | ||
| sample/SpaceInvader/SpaceInvader.cpp | ||
| ) | ||
|
|
||
| add_executable(${PROJECT_NAME}-Tetris-sample | ||
| sample/tetris/Tetris.cpp | ||
| ) | ||
|
|
||
| add_executable(${PROJECT_NAME}-MusicPlayer-sample | ||
| sample/MusicPlayer/MusicPlayer.cpp | ||
| ) | ||
| add_executable(BattleSpawn | ||
| sample/BattleSpawn/BattleSpawn.cpp | ||
| ) | ||
| add_executable(PacmanClone | ||
| sample/Pacman/Pacman.cpp | ||
| ) | ||
|
|
||
| add_executable(BattleCityRecreation | ||
| sample/BattleCityRecreation/BattleCityRecreation.cpp | ||
| ) | ||
|
|
||
| # to build sample needs | ||
| # Zip support, ubuntu sudo apt-get install libzip-dev | ||
| #target_link_libraries(${PROJECT_NAME}-sample PRIVATE | ||
| # ${PROJECT_NAME} | ||
| # ${DOENGINE_LIBRARIES} | ||
| #) | ||
|
|
||
| target_link_libraries(${PROJECT_NAME}-pong-sample PRIVATE | ||
| ${PROJECT_NAME} | ||
| ${DOENGINE_LIBRARIES} | ||
| ) | ||
|
|
||
| target_link_libraries(${PROJECT_NAME}-SpaceInvader-sample PRIVATE | ||
| ${PROJECT_NAME} | ||
| ${DOENGINE_LIBRARIES} | ||
| ) | ||
|
|
||
| target_link_libraries(${PROJECT_NAME}-Tetris-sample PRIVATE | ||
| ${PROJECT_NAME} | ||
| ${DOENGINE_LIBRARIES} | ||
| ) | ||
|
|
||
| target_link_libraries(${PROJECT_NAME}-MusicPlayer-sample PRIVATE | ||
| ${PROJECT_NAME} | ||
| ${DOENGINE_LIBRARIES} | ||
| ) | ||
|
|
||
| target_link_libraries(BattleSpawn PRIVATE | ||
| ${PROJECT_NAME} | ||
| ${DOENGINE_LIBRARIES} | ||
| ) | ||
|
|
||
| target_link_libraries(PacmanClone PRIVATE | ||
| ${PROJECT_NAME} | ||
| ${DOENGINE_LIBRARIES} | ||
| ) | ||
|
|
||
|
|
||
| target_link_libraries(BattleCityRecreation PRIVATE | ||
| ${PROJECT_NAME} | ||
| ${DOENGINE_LIBRARIES} | ||
| ) | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Moved to sample/CMakeLists.txt
Comment on lines
-11
to
+13
| #include <SDL2/SDL_image.h> | ||
| #include <SDL2/SDL_ttf.h> | ||
| #include <SDL2/SDL_mixer.h> | ||
| #include <SDL_image.h> | ||
| #include <SDL_ttf.h> | ||
| #include <SDL_mixer.h> |
Collaborator
Author
There was a problem hiding this comment.
Verify if this causes you problems @aneury1
Collaborator
Author
aneury1
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.