feat: allow increasing page_size for device query#290
Open
shurick2 wants to merge 1 commit intoannetutil:mainfrom
Open
feat: allow increasing page_size for device query#290shurick2 wants to merge 1 commit intoannetutil:mainfrom
shurick2 wants to merge 1 commit intoannetutil:mainfrom
Conversation
shurick2
force-pushed
the
tweak_dev_page_size
branch
from
690ba3a to
74f5be3
Compare
Contributor
Author
Contributor
|
I am not sure, that reading env variables is a good idea for a library |
Tishka17
reviewed
May 22, 2025
| from annet.storage import Storage | ||
| from .models import IpAddressV37, NetboxDeviceV37, InterfaceV37, PrefixV37 | ||
|
|
||
| interfaces_page_size = int(os.getenv("NETBOX_INTERFACES_PAGE_SIZE", 100)) |
Contributor
There was a problem hiding this comment.
we should move this logic to NetboxStorageOpts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.