Optimize JSI to ByteBuffer conversion in RevocationRegistry#8
Conversation
…ate string step Signed-off-by: AhmedFatthy1040 <eltonsy1040@outlook.sa>
030071a to
3a63d5d
Compare
|
@andrewwhitehead — can you please take a look and approve? Looks fine to me, but I’m not knowledgeable enough in the code. |
|
Actually, it should be @berendsliedrecht or @TimoGlastra that takes a look, pretty please. |
berendsliedrecht
left a comment
There was a problem hiding this comment.
Has this been tested in the React Native example app? Can you add a screenshot?
|
@swcurran @berendsliedrecht Thanks for your review! I actually built the code, and it compiled successfully without any errors. I tried the React Native example as you suggested, but I noticed that it only uses |
|
@AhmedFatthy1040 Thanks! Did you check all the places where it could be replaced? Or was it only the revregdeffromjson? Re the version 0.2.0, thats fine. It is mainly a test to see that everything compiled correctly. |
Signed-off-by: AhmedFatthy1040 <eltonsy1040@outlook.sa>
532055d to
aea1db7
Compare
|
@berendsliedrecht I've now checked all the functions in similar situations and handled them as well. After making the changes, I tested the app and it compiled successfully. |
|
Thanks for the PR @AhmedFatthy1040 |


Added direct JSI to ByteBuffer conversion by implementing
jsiToValue<ByteBuffer>, eliminating the intermediate string conversion step. Applied this optimization torevocationRegistryFromJsonas specified in issue anoncreds/anoncreds-rs#176. This makes the code cleaner and more efficient by reducing unnecessary memory allocations.