fix: Viz Mesh in CHT example. #4767
Open
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prmukherj
requested review from
hpohekar,
mayankansys,
mkundu1 and
seanpearsonuk
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a missing required argument in the Mesh object instantiation within the conjugate heat transfer example. The surfaces parameter was added as an explicit empty list during construction, ensuring proper initialization before surfaces are populated later.
Key Changes
- Added
surfaces=[]as a constructor argument to the Mesh object instantiation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
added
documentation
Gobot1234
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
One of the construction arguments 'surfaces' for 'Mesh' was missing in this particular example.
Change Summary
'surfaces' was added as a construction argument for mesh.
Rationale
Initially "surfaces=[]" has been done during construction of mesh, following which the allowed values of surfaces are queried and re-populated again. However, during construction of any objects like 'mesh', the construction arguments, or the compulsory arguments must be passed.
Impact
Only this particular example is updated. No other impact.