Open
Conversation
Contributor
|
looks like same issue that #197 addressing. Also, I think an actor with max restart set to 0 should not execute the recover() block |
Author
gabrielluizsf
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently any crashed actor with maxRestarts(0) leads to unrecovered panic.
e.g. in this example -- https://github.com/anthdm/hollywood/blob/master/examples/restarts/main.go
the culprit for that is
nilargument passed tofuncparam incleanupfunction.After the fix
no crashes, expected log message.