refactor(cli): always print errors when using the cli#3
Open
nikoksr wants to merge 2 commits intoanthdm:masterfrom
Open
refactor(cli): always print errors when using the cli#3nikoksr wants to merge 2 commits intoanthdm:masterfrom
nikoksr wants to merge 2 commits intoanthdm:masterfrom
Conversation
Prior to this change, `slick run` did not print any errors that were caused by the underlying run implementation, which required the user to use `go run` manually to find out what's wrong. This change fixes that, and also pipes the stderr of all commands into the OS' stderr which should help with debugging things. To achieve that, I abstracted the command logic and added the `commandOptions` type. I chose an options type over passing a `verbose` parameter directly, this keeps things more flexible and maintainable down the line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this change,
slick rundid not print any errors that were caused by the underlying run implementation, which required the user to usego runmanually to find out what's wrong.This change fixes that, and also pipes the stderr of all commands into the OS' stderr which should help with debugging things.
To achieve that, I abstracted the command logic and added the
commandOptionstype. I chose an options type over passing averboseparameter directly, to keep things more flexible down the line.