Tony/186 migration

[tonypioneer]

Pull Request Details

What issue does this PR address

• Migrated security key related UI elements from SolidPod.

Associated Issue

• This PR relates to issue SOLIDUI: Migrate SecurityKeyUi(), SecretTextField() and SecurityColors to SolidUI #186.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Build and run the app.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

• Screenshots included in linked issue SOLIDUI: Migrate SecurityKeyUi(), SecretTextField() and SecurityColors to SolidUI #186
• Changes adhere to the style and coding guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• Any dependent changes have been merged and published in downstream modules
• The update contains no confidential information
• The update has no duplicated content
• No lint check errors are related to these changes (make prep or flutter analyze lib)
• Integration test dart test output or screenshot included in issue #
• I tested the PR on these devices:
  • Android
  • iOS
  • Linux
  • MacOS
  • Windows
  • Web
• I have identified reviewers
• The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

• Merge dev into the this branch
• Resolve any conflicts
• Add a one line summary into the CHANGELOG.md
• Push to the git repository and review
• Merge the PR into dev

[gjwgit]

Is this really "non-breaking" I think it does mean we need to add solidui to different source files?

Testing using a suite of apps adding branch tony/186_migration into pubspec.yaml resulting in:

! solidpod 0.9.15 from git https://github.com/anusii/solidpod.git at f9074c (overridden)
! solidui 0.0.34 from git https://github.com/anusii/solidui.git at b8672c (overridden)

Might be an issue with the solidui update. This is common:

ERROR: ../../../../.pub-cache/git/solidui-b8672cd963b1117614fc7d8ca9f717fa62d5b61a/lib/src/utils/solid_pod_helpers.dart:92:16: Error: Undefined name 'SecurityStrings'.
ERROR:       message: SecurityStrings.securityKeyPrompt,
ERROR:                ^^^^^^^^^^^^^^^
ERROR: ../../../../.pub-cache/git/solidui-b8672cd963b1117614fc7d8ca9f717fa62d5b61a/lib/src/utils/solid_pod_helpers.dart:89:30: Error: Method not found: 'SecurityKeyUI'.
ERROR:     final securityKeyInput = SecurityKeyUI(
ERROR:                              ^^^^^^^^^^^^^
ERROR: ../../../../.pub-cache/git/solidui-b8672cd963b1117614fc7d8ca9f717fa62d5b61a/lib/src/widgets/solid_security_key_manager_dialogs.dart:51:13: Error: Method not found: 'changeKeyPopup'.
ERROR:       await changeKeyPopup(context, appWidget);
ERROR:             ^^^^^^^^^^^^^^
ERROR: Target kernel_snapshot_program failed: Exception
Error: Build process failed

Currently failing:

• geopod: Many files need attention
• bookoflife: SecurityStrings() from solidui error
• notepod: SecurityStrings, WindowSize
• healthpod: etc

[jesscmoore]

@tonypioneer I had similar issues to @gjwgit testing on notepod. Possibly a circular dependency problem between solidpod and solidui. Perhaps its time to move the UI functions around grant permissions to solidui also.

I've submitted a notepod PR anusii/notepod#355 to source WindowSize() from solidui, which will resolve the notepod side of things, if tony/186_migration in solidpod and solidui are merged.

[jesscmoore]

The remaining UI files that would need moving from solidpod to solidui to clear up the dependency issues are the 10 in the screenshot below. Files 1-3, 7-8 relate to permissions, files 5,9-10 relate to security key, file 4 is used in the solidpod example, file 6 file explorer probably in various apps. So this would be a breaking change as apps would need to import from solidui.

Can this migration wait a couple of days, until jess/572_perm_history is merged in solidpod, adding permission history functionality?

[tonypioneer]

The remaining UI files that would need moving from solidpod to solidui to clear up the dependency issues are the 10 in the screenshot below. Files 1-3, 7-8 relate to permissions, files 5,9-10 relate to security key, file 4 is used in the solidpod example, file 6 file explorer probably in various apps. So this would be a breaking change as apps would need to import from solidui.

Can this migration wait a couple of days, until jess/572_perm_history is merged in solidpod, adding permission history functionality?

Sure. Thanks Jess.

[tonypioneer]

Is this really "non-breaking" I think it does mean we need to add solidui to different source files?

Testing using a suite of apps adding branch tony/186_migration into pubspec.yaml resulting in:

! solidpod 0.9.15 from git https://github.com/anusii/solidpod.git at f9074c (overridden)
! solidui 0.0.34 from git https://github.com/anusii/solidui.git at b8672c (overridden)

Might be an issue with the solidui update. This is common:

ERROR: ../../../../.pub-cache/git/solidui-b8672cd963b1117614fc7d8ca9f717fa62d5b61a/lib/src/utils/solid_pod_helpers.dart:92:16: Error: Undefined name 'SecurityStrings'.
ERROR:       message: SecurityStrings.securityKeyPrompt,
ERROR:                ^^^^^^^^^^^^^^^
ERROR: ../../../../.pub-cache/git/solidui-b8672cd963b1117614fc7d8ca9f717fa62d5b61a/lib/src/utils/solid_pod_helpers.dart:89:30: Error: Method not found: 'SecurityKeyUI'.
ERROR:     final securityKeyInput = SecurityKeyUI(
ERROR:                              ^^^^^^^^^^^^^
ERROR: ../../../../.pub-cache/git/solidui-b8672cd963b1117614fc7d8ca9f717fa62d5b61a/lib/src/widgets/solid_security_key_manager_dialogs.dart:51:13: Error: Method not found: 'changeKeyPopup'.
ERROR:       await changeKeyPopup(context, appWidget);
ERROR:             ^^^^^^^^^^^^^^
ERROR: Target kernel_snapshot_program failed: Exception
Error: Build process failed

Currently failing:

• geopod: Many files need attention
• bookoflife: SecurityStrings() from solidui error
• notepod: SecurityStrings, WindowSize
• healthpod: etc

Hi @gjwgit, the issue has been fixed. Tests have passed on GeoPod, BookOfLife, NotePod, and HealthPod.

[jesscmoore]

Thanks @tonypioneer - tested in notepad - worked great after your fixes!

In notepad I used jess/354_use_solidui_windowsize to source WindowSize from solidui, and with solidui and solidpod pointed to tony/186_migration.
This is a breaking change for notepad, and notepad jess/354_use_solidui_windowsize will need merging afterwards.