[WIP]refactor: Move command implementations to separate types and clean up application bootstrap#365
Open
[WIP]refactor: Move command implementations to separate types and clean up application bootstrap#365
Conversation
… a separate class
…t the right implementation in RenderTemplateTask Remove the need to conditioally configure the DI container by no longer registering a single instance of ITemplate based on the configuration. Instead, register all implementations and select the right implementation based in the configuraion in RenderTemplateTask. This (along with future refactorings) will enable composing the application / creating the DI container independently of the configuration
…ridesFromGitNotesTask to the pipeline Instead of conditionally adding the LoadMessageOverridesFromFileSystemTask and LoadMessageOverridesFromGitNotesTask tasks based on the configuration, always add the tasks but skip the tasks if the corresponding feature is not enabled in the configuration
Instead of conditionally adding the GitHubLinkTask and GitLabLinkTask tasks based on the configuration, always add the tasks but skip the tasks if the corresponding integration is not enabled in the configuration.
Remove ChangeLogPipelineBuilder and directory create ChangeLogPipeline through the DI container (injecting all regsitered implementations of IChangeLogTask)
ap0llo
force-pushed
the
refactor/separate-command-implementations
branch
from
a1544b9 to
a9a9b3a
Compare
Add CompositionRoot which will be responsible for creating all commands and required types. Currently, the implementation is incomplete and composition is still split between CompositionRoot and GenerateCommand (which uses the Autofac DI container)
ap0llo
force-pushed
the
refactor/separate-command-implementations
branch
from
a9a9b3a to
127dbb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODOs