Skip to content

Updated branch with 4.0 changes#294

Closed
ctubbsii wants to merge 1 commit intoapache:mainfrom
ctubbsii:elasticity
Closed

Updated branch with 4.0 changes#294
ctubbsii wants to merge 1 commit intoapache:mainfrom
ctubbsii:elasticity

Conversation

@ctubbsii
Copy link
Member

@ctubbsii ctubbsii commented Apr 9, 2025

Updated accumulo-testing branch with Accumulo 4.0.0-SNAPSHOT changes. Copied AccessExpression normalization code, which is used to replace ColumnVisibility.flatten, from ParseExamples in Accumulo-Access.

Updated accumulo-testing branch with Accumulo 4.0.0-SNAPSHOT
changes. Copied AccessExpression normalization code, which
is used to replace ColumnVisibility.flatten, from ParseExamples
in Accumulo-Access.
@ctubbsii
Copy link
Member Author

ctubbsii commented Apr 9, 2025

This PR preserves a copy of a branch that was recently deleted that @dlmarion was working on. I didn't know if it needed to be kept, but since it contained unmerged changes, I made a copy of the deleted branch, and opened this PR for him to review, in case anything from it is still needed. There is one small conflict.

@dlmarion
Copy link
Contributor

dlmarion commented Apr 9, 2025

@ctubbsii - Thanks for preserving this. The issue I believe was that my local copy of main was out of date and I didn't realize it. Locally I saw it still depending on Accumulo 3.1.0-SNAPSHOT. I didn't remember the history of the repo and that elasticity had already been merged to main. So I started updating my local copy of elasticity with the latest Accumulo 4.0.0-SNAPSHOT changes. My approach to resolving the removal of ColumnVisibility.flatten was to try and retain the normalization and deduplication that it did versus just using the expression. It looks like @DomGarguilo resolved this issue in #290, so I decided to abort my change.

main current builds with no issue.

@ctubbsii ctubbsii closed this Apr 9, 2025
@ctubbsii ctubbsii deleted the elasticity branch April 9, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants