PATCH - Performance can be increased if replaceAll() does not use a r…#14
Open
bd2019us wants to merge 1 commit intoapache:trunkfrom
Open
PATCH - Performance can be increased if replaceAll() does not use a r…#14bd2019us wants to merge 1 commit intoapache:trunkfrom
bd2019us wants to merge 1 commit intoapache:trunkfrom
Conversation
…egex by replace replaceAll() with replace(). ReplaceAll() costs some performance overhead by compiling the regex whereas replace() does not incur this performance overhead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…egex by replacing replaceAll() with replace(). ReplaceAll() costs some performance overhead by compiling the regex whereas replace() does not incur this performance overhead.