Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Dec 16, 2025

Rationale for this change

It's a large variant of UTF-8 array.

What changes are included in this PR?

  • Add ArrowFormat::LargeUTF8Type
  • Add ArrowFormat::LargeUTF8Array

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@github-actions
Copy link

⚠️ GitHub issue #48551 has been automatically assigned in GitHub to PR creator.

Copy link
Collaborator

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

LD_LIBRARY_PATH=/tmp/local/lib GI_TYPELIB_PATH=/tmp/local/lib/girepository-1.0 rake test
cd /path/to/arrow/ruby/red-arrow-format
/path/to/.rbenv/versions/3.4.7/bin/ruby test/run.rb
Loaded suite test
Started
/path/to/arrow/ruby/red-arrow-format/lib/arrow-format/file-reader.rb:69: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
Finished in 0.395363417 seconds.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
29 tests, 29 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
73.35 tests/s, 73.35 assertions/s
cd -

@kou kou merged commit 4cbe26d into apache:main Dec 16, 2025
10 checks passed
@kou kou deleted the ruby-large-utf8-array branch December 16, 2025 21:37
@kou kou removed the awaiting committer review Awaiting committer review label Dec 16, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 4cbe26d.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants