GH-48553: [Ruby] Add support for reading timestamp array #48554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Ruby
awaiting committer review
hiroyuki-sato
suggested changes
Dec 16, 2025
| attr_reader :unit | ||
| attr_reader :timezone | ||
| def initialize(unit, timezone) | ||
| super("Temporal") |
Collaborator
There was a problem hiding this comment.
Is this correct? super("Timestamp")?
| sub_test_case("Timestamp(:second)") do | ||
| def setup(&block) | ||
| @timestamp_2019_11_18_00_09_11 = 1574003351 | ||
| @timestamp_2025_12_16_05_33_58 = 1765863238 |
Collaborator
There was a problem hiding this comment.
Suggested change
| @timestamp_2025_12_16_05_33_58 = 1765863238 | |
| @timestamp_2025_12_16_05_33_58 = 1765830838 |
[6] pry(main)> Time.new(2025,12,16,5,33,58).to_i
=> 1765830838
| sub_test_case("Timestamp(:millisecond)") do | ||
| def setup(&block) | ||
| @timestamp_2019_11_18_00_09_11 = 1574003351 * 1_000 | ||
| @timestamp_2025_12_16_05_33_58 = 1765863238 * 1_000 |
Collaborator
There was a problem hiding this comment.
Suggested change
| @timestamp_2025_12_16_05_33_58 = 1765863238 * 1_000 | |
| @timestamp_2025_12_16_05_33_58 = 1765830838 * 1_000 |
[6] pry(main)> Time.new(2025,12,16,5,33,58).to_i
=> 1765830838
| sub_test_case("Timestamp(:microsecond)") do | ||
| def setup(&block) | ||
| @timestamp_2019_11_18_00_09_11 = 1574003351 * 1_000_000 | ||
| @timestamp_2025_12_16_05_33_58 = 1765863238 * 1_000_000 |
Collaborator
There was a problem hiding this comment.
Suggested change
| @timestamp_2025_12_16_05_33_58 = 1765863238 * 1_000_000 | |
| @timestamp_2025_12_16_05_33_58 = 1765830838 * 1_000_000 |
[6] pry(main)> Time.new(2025,12,16,5,33,58).to_i
=> 1765830838
| sub_test_case("Timestamp(:nanosecond)") do | ||
| def setup(&block) | ||
| @timestamp_2019_11_18_00_09_11 = 1574003351 * 1_000_000_000 | ||
| @timestamp_2025_12_16_05_33_58 = 1765863238 * 1_000_000_000 |
Collaborator
There was a problem hiding this comment.
Suggested change
| @timestamp_2025_12_16_05_33_58 = 1765863238 * 1_000_000_000 | |
| @timestamp_2025_12_16_05_33_58 = 1765830838 * 1_000_000_000 |
[6] pry(main)> Time.new(2025,12,16,5,33,58).to_i
=> 1765830838
| def setup(&block) | ||
| @timezone = "UTC" | ||
| @timestamp_2019_11_18_00_09_11 = 1574003351 | ||
| @timestamp_2025_12_16_05_33_58 = 1765863238 |
Collaborator
There was a problem hiding this comment.
Suggested change
| @timestamp_2025_12_16_05_33_58 = 1765863238 | |
| @timestamp_2025_12_16_05_33_58 = 1765830838 |
[6] pry(main)> Time.new(2025,12,16,5,33,58).to_i
=> 1765830838
| end | ||
|
|
||
| def build_array | ||
| Arrow::TimestampArray.new(:second, |
Collaborator
There was a problem hiding this comment.
Suggested change
| Arrow::TimestampArray.new(:second, | |
| Arrow::TimestampArray.new(:micro, |
| end | ||
|
|
||
| def build_array | ||
| Arrow::TimestampArray.new(:second, |
Collaborator
There was a problem hiding this comment.
Suggested change
| Arrow::TimestampArray.new(:second, | |
| Arrow::TimestampArray.new(:milli, |
Arrow::TimestampArray.new(:second returns value out of range
[8] pry(main)> @timestamp_2019_11_18_00_09_11 = 1574003351 * 1_000
[8] pry(main)> @timestamp_2025_12_16_05_33_58 = 1765863238 * 1_000
=> 1765863238000
[9] pry(main)> Arrow::TimestampArray.new(:second,
[9] pry(main)> [
[9] pry(main)> @timestamp_2019_11_18_00_09_11,
[9] pry(main)> nil,
[9] pry(main)> @timestamp_2025_12_16_05_33_58,
[9] pry(main)> ])
=> #<Arrow::TimestampArray:0x00000001211f2aa8 ptr=0x0000600003c582e0 [
<value out of range: 1574003351000>,
null,
<value out of range: 1765863238000>
]>
| end | ||
|
|
||
| def build_array | ||
| Arrow::TimestampArray.new(:second, |
Collaborator
There was a problem hiding this comment.
Suggested change
| Arrow::TimestampArray.new(:second, | |
| Arrow::TimestampArray.new(:nano, |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 97ea97c. There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It's an array for timestamp.
What changes are included in this PR?
ArrowFormat::TimestampTypeArrowFormat::TimestampArrayAre these changes tested?
Yes.
Are there any user-facing changes?
Yes.