ATLAS-5147: Relationship Search API approximateCount returns pageLimit value instead of total relationship count #2 #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-gupta36
changed the title
aditya-gupta36
force-pushed
the
ATLAS-5163
branch
4 times, most recently
from
8828701 to
4e9ac68
Compare
sheetalshah1007
suggested changes
Dec 8, 2025
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
Outdated
Show resolved
Hide resolved
…t value instead of total relationship count#2
aditya-gupta36
force-pushed
the
ATLAS-5163
branch
from
4e9ac68 to
7749733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previously, The approxCount value in Relationship Search is returned based on the requested limit value instead of actual total number of relationships found.
After the fix, the approxCount accurately reflects the total number of relationships, irrespective of page limit we set
Also Junits added for RelationshipProcessorTest and EntitySearchProcessorTest.
How was this patch tested?