-
Notifications
You must be signed in to change notification settings - Fork 104
Burr Release Scripts #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Burr Release Scripts #609
Conversation
This was missing and is blocking for release. Have to ad a specific workaround for template files (.tpl)
We exclude jsonl. examples is the symlink that it cannot handle So when you run rat, know the examples directory symlink will be a false negative
|
A preview of 472d6a3 is uploaded and can be seen here: ✨ https://burr.dagworks.io/pull/609 ✨ Changes may take a few minutes to propagate. Since this is a preview of production, content with |
182ab9f to
2098608
Compare
2098608 to
db71fe9
Compare
This is a convenience
| Release artifacts are signed with your GPG key. The KEYS file is available at: | ||
| https://downloads.apache.org/incubator/{PROJECT_SHORT_NAME}/KEYS | ||
| Please download, verify, and test the release candidate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include instructions on what to do / how to verify.
scripts/README.md
Outdated
|
|
||
| ### Source tarball (`apache-burr-{version}-incubating.tar.gz`) | ||
| # Verify licenses (requires Apache RAT) | ||
| python scripts/verify_apache_artifacts.py licenses --rat-jar /path/to/apache-rat-0.15.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where do we get the rat jar from?
| @@ -0,0 +1,3 @@ | |||
| .*py\.typed | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably want requirements.txt here too?
skrawcz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need some more instructions in email, and where to get rat-jar from (maybe even cmd to get it?)
|
need to update this PR too and have a commit message for code archaeology. |
9c29cc0 to
21f7684
Compare
21f7684 to
472d6a3
Compare
[Short description explaining the high-level reason for the pull request]
Changes
How I tested this
Notes
Checklist