fix(pydantic): widen stream_type hint to accept type objects #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrawcz
reviewed
Dec 30, 2025
burr/core/action.py
Outdated
| state_input_type: Type["BaseModel"], | ||
| state_output_type: Type["BaseModel"], | ||
| stream_type: Union[Type["BaseModel"], Type[dict]], | ||
| stream_type: Union[Type["BaseModel"], Type[dict], type], |
Contributor
There was a problem hiding this comment.
hmm, pyright didn't seem to like this for me -- rather this doesn't fix it for me.
majiayu000
changed the title
Updated type hints to accept Union types for stream_type parameter in streaming_action.pydantic decorator. This allows users to specify union types like Union[Model1, Model2] for stream_type. Closes apache#607 Signed-off-by: majiayu000 <1835304752@qq.com>
majiayu000
force-pushed
the
fix/607-streaming-union-type-hint
branch
from
883a0fe to
14d7d10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
stream_typeparameter instreaming_action.pydanticChanges
PartialTypeinburr/integrations/pydantic.pystream_typeparameter type instreaming_action.pydanticinburr/core/action.pytest_streaming_pydantic_action_union_stream_type(may not coverModel1 | Model2union objects)Test plan