Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion telemetry/ui/src/components/routes/app/StepList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ const SelfLoadingSubApplicationContainer = (props: {
minimized={props.minimized}
projectId={props.projectId}
topToBottomChronological={props.topToBottomChronological}
displayAnnotations={false} // TODO -- get annotations to work propertly for sub-applications
displayAnnotations={false} // TODO -- get annotations to work properly for sub-applications
traceExpandedActions={traceExpandedActions}
setTraceExpandedActions={setTraceExpandedActions}
linksExpandedActions={linksExpandedActions}
Expand Down
2 changes: 1 addition & 1 deletion tests/core/test_action.py
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ def my_action(


def test_function_based_action_with_defaults_unbound():
# inputs can have defaults -- this tests that we treat them propertly
# inputs can have defaults -- this tests that we treat them properly
@action(reads=["input_variable"], writes=["output_variable"])
def my_action(
state: State, unbound_input_1: int, unbound_input_2: int, unbound_default_input: int = 1000
Expand Down
14 changes: 7 additions & 7 deletions tests/core/test_application.py
Original file line number Diff line number Diff line change
Expand Up @@ -1010,7 +1010,7 @@ def test__run_multistep_streaming_action():
result = None
for result, state in generator:
if last_result < 1:
# Otherwise you hit floating poit comparison problems
# Otherwise you hit floating point comparison problems
assert result["count"] > last_result
last_result = result["count"]
assert result == {"count": 1}
Expand Down Expand Up @@ -1042,7 +1042,7 @@ def post_stream_item(self, item: Any, **future_kwargs: Any):
result = None
for result, state in generator:
if last_result < 1:
# Otherwise you hit floating poit comparison problems
# Otherwise you hit floating point comparison problems
assert result["count"] > last_result
last_result = result["count"]
assert result == {"count": 1}
Expand All @@ -1066,7 +1066,7 @@ async def test__run_multistep_streaming_action_async():
result = None
async for result, state in generator:
if last_result < 1:
# Otherwise you hit floating poit comparison problems
# Otherwise you hit floating point comparison problems
assert result["count"] > last_result
last_result = result["count"]
assert result == {"count": 1}
Expand Down Expand Up @@ -1097,7 +1097,7 @@ async def post_stream_item(self, item: Any, **future_kwargs: Any):
result = None
async for result, state in generator:
if last_result < 1:
# Otherwise you hit floating poit comparison problems
# Otherwise you hit floating point comparison problems
assert result["count"] > last_result
last_result = result["count"]
assert result == {"count": 1}
Expand Down Expand Up @@ -1633,7 +1633,7 @@ def test_iterate_with_inputs():
)
gen = app.iterate(
halt_after=["result"], inputs={"additional_increment": 10}
) # make it go quicly to the end
) # make it go quickly to the end
while True:
try:
action, result, state = next(gen)
Expand Down Expand Up @@ -2425,7 +2425,7 @@ def test_stream_result_halt_after_run_through_final_non_streaming():
)
action, streaming_container = app.stream_result(halt_after=["counter_final_non_streaming"])
results = list(streaming_container)
assert len(results) == 0 # nothing to steram
assert len(results) == 0 # nothing to stream
result, state = streaming_container.get()
assert result["count"] == state["count"] == 11
assert len(action_tracker.pre_called) == 11
Expand Down Expand Up @@ -2519,7 +2519,7 @@ def test_stream_result_halt_before():
)
action, streaming_container = app.stream_result(halt_after=[], halt_before=["counter_final"])
results = list(streaming_container)
assert len(results) == 0 # nothing to steram
assert len(results) == 0 # nothing to stream
result, state = streaming_container.get()
assert action.name == "counter_final" # halt before this one
assert result is None
Expand Down
4 changes: 2 additions & 2 deletions tests/test_end_to_end.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def test_end_to_end_parallel_collatz_many_unreliable_tasks(tmpdir):

MIN_NUMBER = 80
MAX_NUMBER = 100
FAILURE_ODDS = 0.05 # 1 in twenty chance of faiulre, will be hit but not all the time
FAILURE_ODDS = 0.05 # 1 in twenty chance of failure, will be hit but not all the time

seen = set()

Expand Down Expand Up @@ -237,7 +237,7 @@ async def test_end_to_end_parallel_collatz_many_unreliable_tasks_async(tmpdir):

MIN_NUMBER = 80
MAX_NUMBER = 100
FAILURE_ODDS = 0.05 # 1 in twenty chance of faiulre, will be hit but not all the time
FAILURE_ODDS = 0.05 # 1 in twenty chance of failure, will be hit but not all the time

seen = set()

Expand Down
2 changes: 1 addition & 1 deletion tests/tracking/test_local_tracking_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def test_persister_tracks_parent(tmpdir):


def test_multi_fork_tracking_client(tmpdir):
"""This is more of an end-to-end test. We shoudl probably break it out
"""This is more of an end-to-end test. We should probably break it out
into smaller tests but the local tracking client being used as a persister is
a bit of a complex case, and we don't want to get lost in the details.
"""
Expand Down
Loading