Restart xl2tpd service when the VPN configuration is modified

[vishesh92]

Description

Fixes #12195

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[Copilot]

Copilot wasn't able to review any files in this pull request.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.59%. Comparing base (b5fd39f) to head (ef7b083).

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12422      +/-   ##
============================================
- Coverage     17.59%   17.59%   -0.01%     
+ Complexity    15601    15597       -4     
============================================
  Files          5910     5910              
  Lines        529780   529780              
  Branches      64729    64729              
============================================
- Hits          93226    93202      -24     
- Misses       426060   426084      +24     
  Partials      10494    10494              

Flag	Coverage Δ
uitests	3.60% <ø> (ø)
unittests	18.66% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16356

[blueorangutan]

[LL] Trillian Build Failed (tid-7166)

[Copilot]

Copilot wasn't able to review any files in this pull request.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Pearl1594]

can we just not use systemctl restart x12tpd?

[vishesh92]

I am not sure if restarting xl2tpd will drop existing connections or not. So, I didn't want to restart the service unnecessarily.