Skip to content

[DAEMON-477] Detaches from console when the service stops #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avpinchuk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[DAEMON-477] Detaches from console when the service stops #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/native/windows/apps/prunsrv/prunsrv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1999,8 +1999,17 @@ void WINAPI serviceMain(DWORD argc, LPTSTR *argv)
apxLogWrite(APXLOG_MARK_DEBUG "Waiting %d milliseconds for all threads to exit.", timeout);
reportServiceStatus(SERVICE_STOP_PENDING, NO_ERROR, ONE_MINUTE_AS_MILLIS);
if (!apxDestroyJvm(timeout)) {
/* if we are not using JAVA apxDestroyJvm does nothing, check the chid processes in case they hang */
/* if we are not using JAVA apxDestroyJvm does nothing */
apxLogWrite(APXLOG_MARK_DEBUG "apxDestroyJvm did nothing or failed");
/* detach service process from console */
if (GetConsoleWindow() != NULL) {
apxLogWrite(APXLOG_MARK_DEBUG "Detaching service from console");
if (FreeConsole())
apxLogWrite(APXLOG_MARK_DEBUG "Service detached from console");
else
apxLogWrite(APXLOG_MARK_DEBUG "Failed to detach service from console");
}
/* check the chid processes in case they hang */
for (;;) {
if (!apxProcessTerminateChild( GetCurrentProcessId(), TRUE)) {
/* Just print the children processes once for debugging */
Expand Down