Improve IBANValidatorTest - use registry from swift #293
Conversation
slawekjaranowski
commented
Dec 17, 2024
slawekjaranowski
commented
- add iban_registry_v98.txt from swift site
- use parametrized test
slawekjaranowski
force-pushed
the
iban-registry-test
branch
from
944cd1a to
c1df3b4
Compare
src/test/java/org/apache/commons/validator/routines/IBANValidatorTest.java
Outdated
Show resolved
Hide resolved
- add iban_registry_v98.txt from swift site - use parametrized test
slawekjaranowski
force-pushed
the
iban-registry-test
branch
from
c1df3b4 to
2b2596d
Compare
|
TY @slawekjaranowski 😊 |
|
Hi @garydgregory thanks for asking ... I would like do https://issues.apache.org/jira/browse/VALIDATOR-497 and https://issues.apache.org/jira/browse/VALIDATOR-496 |
|
Whilst it is useful to use the test data from SWIFT, this is by no means exhaustive, and only includes on example per country. |
|
The build is broken btw. |
but only on JDK 23+ I hope that this PR doesn't break more ... |
|
AFAICT JDK 23+ failures are due to an incompatible change in Locale handling; nothing to do with this PR. |
|
The failure was due to a checkstyle error. The other failures for Java 23+ are for builds marked experimental, those are known issues. |
3 participants
