#113 (browser) - Properly detect new Edge Chromium version as Edge instead of Chrome#115
Open
mark-veenstra wants to merge 3 commits intoapache:masterfrom
Open
#113 (browser) - Properly detect new Edge Chromium version as Edge instead of Chrome#115mark-veenstra wants to merge 3 commits intoapache:masterfrom
mark-veenstra wants to merge 3 commits intoapache:masterfrom
Conversation
…dge instead of Chrome
Author
|
Any updates? |
|
please review & merge asap =) |
timbru31
requested changes
Mar 26, 2020
Member
timbru31
left a comment
timbru31
left a comment
There was a problem hiding this comment.
Unfortunately, the change won't work.
| if (getModel) { | ||
| returnVal = 'Edge'; | ||
| } else { | ||
| if ((offset = userAgent.indexOf('Edge')) !== -1) { |
Member
There was a problem hiding this comment.
This won't work, as the offset might be set to -1 again and line 47 would return userAgent.substring(-1 + 4);
added 2 commits
July 7, 2020 09:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
browser
Motivation and Context
Allows the plugin to properly detect the new Edge browser based on Chromium.
#113
Description
The new Chromium based Edge browser exposed the following
userAgent:This change detects the browser as Edge instead of Chrome. And pulls the correct version.
Testing
On Edge and on Edge Chromium based execture the plugin and get the model and version
Checklist
(platform)if this change only applies to one platform (e.g.(android))Closes #113