(iOs) Device properties request can crash if invoked on locked device#179
Open
RSATom wants to merge 4 commits intoapache:masterfrom
Open
(iOs) Device properties request can crash if invoked on locked device#179RSATom wants to merge 4 commits intoapache:masterfrom
RSATom wants to merge 4 commits intoapache:masterfrom
Conversation
RSATom
changed the title
RSATom
force-pushed
the
deviceProperties-fix
branch
from
f1789aa to
b8689d3
Compare
to allow acess to it from locked phone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOs
Motivation and Context
I think it should fix #108
Description
Just replace nil values with empty string since NSDictionary crashes in that case
Testing
Don't sure how to test it, since it's pretty rare case.
Checklist
(platform)if this change only applies to one platform (e.g.(android))