allow uuid being created and managed by kubernetes #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
willholley
force-pushed
the
colearendt-close-39
branch
4 times, most recently
from
31349c2 to
5299ffe
Compare
We utilize Helm's `lookup` command to store a generated `uuid` in an "internal" secret in Kubernetes. This allows generating the `uuid`, making it persistent, and notifying the user (in `NOTES.txt`) that this auto-generation happened. We also tell the user how to disable the message by making that value persistent in values. close #39
willholley
force-pushed
the
colearendt-close-39
branch
from
5299ffe to
8540d8a
Compare
Member
Author
|
I don't think this approach is going to work as-is because there is a race between the configmap where the uuid is used and the secret which persists it for the helper. We'll need to put all the components referencing the generated value in the same file (helm/helm#6456). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We utilize Helm's
lookupcommand to store a generateduuidin an "internal" secret in Kubernetes. This allows generating theuuid, making it persistent, and notifying the user (inNOTES.txt) that this auto-generation happened. We also tell the user how to disable the message by making that value persistent in values.Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.