Skip to content

Comments

[test](hive) run suite cases both in hive2 and hive3#33874

Merged
morningman merged 13 commits intoapache:masterfrom
suxiaogang223:regress_test_for_both_hive
Apr 23, 2024
Merged

[test](hive) run suite cases both in hive2 and hive3#33874
morningman merged 13 commits intoapache:masterfrom
suxiaogang223:regress_test_for_both_hive

Conversation

@suxiaogang223
Copy link
Contributor

@suxiaogang223 suxiaogang223 commented Apr 19, 2024 •
edited
Loading

Proposed changes

Followup: #33115
There are hive2 and hive3 dockers in regress-test, so the the original test cases need to be tested in hive2 and hive3 environments.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Apr 19, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@suxiaogang223 suxiaogang223 marked this pull request as draft April 19, 2024 03:57
@suxiaogang223 suxiaogang223 changed the title Regress test for both hive [test](hive) run suite cases both in hive2 and hive3 Apr 19, 2024
@suxiaogang223 suxiaogang223 marked this pull request as ready for review April 19, 2024 06:19
@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Apr 19, 2024

run buildall

@suxiaogang223 suxiaogang223 force-pushed the regress_test_for_both_hive branch from 9e125ad to f4606ca Compare April 19, 2024 06:25
@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Apr 19, 2024

run buildall

8 similar comments
@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Apr 19, 2024

run buildall

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Apr 20, 2024

run buildall

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Apr 20, 2024

run buildall

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Apr 20, 2024

run buildall

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Apr 20, 2024

run buildall

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Apr 20, 2024

run buildall

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Apr 21, 2024

run buildall

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Apr 21, 2024

run buildall

@suxiaogang223
distinguished hive2 and hive3 by prefix
2c82037 
update hive name to hive2

add hivePrefix in Suite

fix

finish hive_read

finish part hive case

finish hive cases

finish paimon cases

finish suit cases for hive2 and hive3

reset hive2 port to default
@suxiaogang223
update pipeline conf for hive
0f599c0
@suxiaogang223
fix suite cases failed
c3c565b
@suxiaogang223
fix test_hive_basic_type
8771e44
@suxiaogang223
fix case
65789f4
@suxiaogang223
revert some change
994862d
@suxiaogang223
set HIVE_SITE_CONF_hive_compactor_initiator_on for hive2
0f90b83 
and can't set HIVE_SITE_CONF_hive_compactor_initiator_on in hive3
@suxiaogang223
revert enableHiveTest inf regression-conf to false
7fe7b7a
@suxiaogang223 suxiaogang223 force-pushed the regress_test_for_both_hive branch from c42bda3 to 7fe7b7a Compare April 22, 2024 02:41
@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Apr 22, 2024

run buildall

@morningman
Copy link
Contributor

morningman commented Apr 22, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Apr 22, 2024

TeamCity be ut coverage result:
Function Coverage: 35.37% (8916/25209)
Line Coverage: 27.09% (73318/270610)
Region Coverage: 26.23% (37868/144362)
Branch Coverage: 23.05% (19289/83696)
Coverage Report: http://coverage.selectdb-in.cc/coverage/60754a72c5d2ca04b1a5d6583c222e24195e42a8_60754a72c5d2ca04b1a5d6583c222e24195e42a8/report/index.html

@morningman
Copy link
Contributor

morningman commented Apr 23, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 23, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024

PR approved by anyone and no changes requested.

@morningman morningman merged commit c530759 into apache:master Apr 23, 2024
@suxiaogang223 suxiaogang223 deleted the regress_test_for_both_hive branch April 24, 2024 03:20
morningman pushed a commit to morningman/doris that referenced this pull request Apr 26, 2024
@suxiaogang223 @morningman
[test](hive) run suite cases both in hive2 and hive3 (apache#33874)
e7aec24 
Followup: apache#33115
There are hive2 and hive3 dockers in regress-test, so the the original test cases need to be tested in hive2 and hive3 environments.
@morningman morningman mentioned this pull request Apr 26, 2024
Merged
morningman added a commit that referenced this pull request Apr 26, 2024
@morningman @suxiaogang223
[test](hive) run suite cases both in hive2 and hive3 (#33874) (#34156)
50f9d47 
bp #33874

Co-authored-by: 苏小刚 <suxiaogang223@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@wuwenchi wuwenchi wuwenchi approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suxiaogang223 @doris-robot @morningman @wuwenchi