-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[hotfix] re-enable unit tests in pyflink test_kafka.py #27408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| # limitations under the License. | ||
| ################################################################################ | ||
| import json | ||
| import unittest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a Python CI test seems is failing.
| # limitations under the License. | ||
| ################################################################################ | ||
| import json | ||
| import unittest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi there is a discussion on slack around levels of Python and connectors that support Flink version 2. @ferenc-csaky is this related?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be, but on the same note I don't even understand why these tests are sitting in this repo and not move into flink-connector-kafka. There might be a reason, but IDK.
What is the purpose of the change
re-enable unit tests in pyflink test_kafka.py
they are disabled over 2 year ago temporarily, but never re-enabled
Brief change log
re-enable unit tests in pyflink test_kafka.py
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Documentation
n/a