Skip to content

Conversation

@bowenli86
Copy link
Member

@bowenli86 bowenli86 commented Jan 13, 2026

What is the purpose of the change

re-enable unit tests in pyflink test_kafka.py

they are disabled over 2 year ago temporarily, but never re-enabled

Brief change log

re-enable unit tests in pyflink test_kafka.py

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

Documentation

n/a

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 13, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

# limitations under the License.
################################################################################
import json
import unittest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a Python CI test seems is failing.

# limitations under the License.
################################################################################
import json
import unittest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi there is a discussion on slack around levels of Python and connectors that support Flink version 2. @ferenc-csaky is this related?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be, but on the same note I don't even understand why these tests are sitting in this repo and not move into flink-connector-kafka. There might be a reason, but IDK.

@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants