chore: Update the InternalRow Trait: get_binary, get_bytes to return &[u8] #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@luoyuxia Would you mind to take a look when you have time? |
crates/fluss/src/row/mod.rs
Outdated
|
|
||
| fn get_bytes(&self, pos: usize) -> Vec<u8> { | ||
| self.values.get(pos).unwrap().as_blob().to_vec() | ||
| fn get_bytes(&self, pos: usize) -> &[u8] { |
Contributor
There was a problem hiding this comment.
nit, formatting: there's an additional space before &[u8]
leekeiabstraction
approved these changes
Dec 20, 2025
luoyuxia
approved these changes
Dec 21, 2025
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@Kelvinyu1117 Thanks. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #85
Update the InternalRow Trait:
get_binary,get_bytesto return&[u8]. However, I keep the C++ binding to usevectorfor now as it might require some changes to theFfiDatum.Brief change log
Tests
API and Format
Documentation