chore: optimize get_char method #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR optimizes the get_char method in the InternalRow trait and its implementations by changing the return type from String to &str and removing length validation to align with Java client behavior.
Key Changes:
- Modified the
InternalRow::get_char()trait method signature to return&strinstead ofString - Removed length validation logic from both
GenericRowandColumnarRowimplementations - Changed UTF-8 error handling in
ColumnarRowfrom lossy conversion to strict validation with panic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| crates/fluss/src/row/mod.rs | Updated trait signature and GenericRow implementation to return borrowed string reference and removed length validation |
| crates/fluss/src/row/column.rs | Updated ColumnarRow implementation to return borrowed string reference, removed length check and lossy UTF-8 fallback |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luoyuxia
force-pushed
the
get_char_optimize
branch
from
be108f6 to
a41456b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Brief change log
Tests
API and Format
Documentation