chore: add integration tests for subscribe_batch and project_by_name #116
Conversation
Add two new integration tests to improve API coverage: - test_subscribe_batch: tests LogScanner::subscribe_batch() with HashMap - test_project_by_name: tests TableScan::project_by_name() with column names Both tests include error case validation.
|
Good morning and thanks for running the workflows! i updated the assertion to Note: clippy is pointing many more warnings in other tests, while this is still fine, its something that should be examinated in the future |
| assert!((1..=6).contains(&id), "id should be between 1 and 6"); | ||
| assert!( | ||
| ["a", "b", "c", "d", "e", "f"].contains(&value), | ||
| "value should be one of a-f" | ||
| ); |
There was a problem hiding this comment.
Should we check the ordering of the records?
There was a problem hiding this comment.
Agree
good catch, thank you
sort records by offset and verify exact ordering.
|
|
||
| let records: Vec<_> = scan_records.into_iter().collect(); | ||
| let mut records: Vec<_> = scan_records.into_iter().collect(); | ||
| records.sort_by_key(|r| r.offset()); |
There was a problem hiding this comment.
Curious, is this sort_by_key needed? What happens if you do not sort?
My assumption is that poll_batch should already return records ordered by offset.
|
The This follows the existing pattern in the codebase:
|
2 participants
test_subscribe_batch: testsLogScanner::subscribe_batch()with HashMaptest_project_by_name: testsTableScan::project_by_name()with column namesLinked issue: #31