Skip to content

Chore: Rust client to return error when currently unimplemented non-default ZSTD compression is configured #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leekeiabstraction wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Chore: Rust client to return error when currently unimplemented non-default ZSTD compression is configured #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions crates/fluss/src/compression/arrow_compression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,20 @@ impl ArrowCompressionInfo {
e
),
}),

Some(Ok(level)) => Ok(Self {
compression_type,
compression_level: level,
}),
Some(Ok(level)) => {
// TODO Remove once non-default ZSTD compression level is implemented https://github.com/apache/fluss-rust/issues/109
if level != DEFAULT_ZSTD_COMPRESSION_LEVEL {
return Err(Error::IoUnsupported {
message: format!(
"Rust client currently only implements default ZSTD compression level {DEFAULT_ZSTD_COMPRESSION_LEVEL}. Got: {level}"
),
});
}
Ok(Self {
compression_type,
compression_level: level,
})
}
None => Ok(Self {
compression_type,
compression_level: DEFAULT_ZSTD_COMPRESSION_LEVEL,
Expand Down Expand Up @@ -171,11 +180,19 @@ mod tests {
"ZSTD",
)]));
assert_eq!(compression_info.unwrap().compression_level, 3);
let compression_info = ArrowCompressionInfo::from_conf(&mk_map(&[
}

// TODO Remove once non-default ZSTD compression level is implemented https://github.com/apache/fluss-rust/issues/109
#[test]
fn test_from_conf_zstd_compression_level_error_when_non_default() {
let result = ArrowCompressionInfo::from_conf(&mk_map(&[
("table.log.arrow.compression.type", "ZSTD"),
("table.log.arrow.compression.zstd.level", "1"),
]));
assert_eq!(compression_info.unwrap().compression_level, 1);
assert!(result.is_err());
assert!(result.unwrap_err().to_string().contains(
"Rust client currently only implements default ZSTD compression level 3. Got: 1."
));
}

#[test]
Expand Down