Skip to content

Conversation

@tisonkun
Copy link
Member

Newer OpenDAL version uses jiff which is proper maintained with better documented features.

... also remove now unnecessary once_cell dep since they are provided from std::sync.

Signed-off-by: tison <wander4096@gmail.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades OpenDAL from version 0.53.3 to 0.55.0 and migrates the project's datetime handling from chrono to jiff, which is better maintained and has better documented features. Additionally, it removes the once_cell dependency in favor of the standard library's LazyLock (available since Rust 1.80), and relocates the build.rs file from src/build.rs to the standard build.rs location at the crate root.

  • Migrated all datetime handling from chrono to jiff library
  • Replaced once_cell::sync::Lazy with std::sync::LazyLock throughout the codebase
  • Upgraded OpenDAL dependency from 0.53.3 to 0.55.0

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
Cargo.toml Updated workspace dependencies from chrono to jiff
bindings/python/Cargo.toml Removed chrono and once_cell dependencies, added jiff
bindings/python/src/lib.rs Replaced once_cell::sync::Lazy with std::sync::LazyLock
crates/fluss/Cargo.toml Removed build script path, updated chrono to jiff, removed once_cell, upgraded OpenDAL to 0.55.0, added wasm32 target with jiff js feature
crates/fluss/build.rs Relocated from src/build.rs to standard build.rs at crate root
crates/fluss/src/io/file_io.rs Migrated from chrono::DateTime<Utc> to jiff::Timestamp for file metadata timestamps
crates/fluss/src/row/datum.rs Migrated from chrono::NaiveDate to jiff::civil::Date, updated Date methods to use jiff's type system (return types changed from i32 to i16/i8)
crates/fluss/tests/integration/admin.rs Replaced once_cell::sync::Lazy with std::sync::LazyLock
crates/fluss/tests/integration/table.rs Replaced once_cell::sync::Lazy with std::sync::LazyLock
crates/fluss/tests/integration/table_remote_scan.rs Replaced once_cell::sync::Lazy with std::sync::LazyLock

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisonkun Thank you very much. LGTM

@luoyuxia luoyuxia merged commit 9054401 into main Dec 15, 2025
19 checks passed
@tisonkun tisonkun deleted the adopt-jiff branch December 15, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants