parse_ipc_message should return exception instead of return None if parse failed #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… message length or bad continuation marker
… message length or bad continuation marker
Contributor
Author
|
@luoyuxia Would appreciate a review here |
luoyuxia
reviewed
Dec 19, 2025
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@leekeiabstraction Thanks for your pr. Left minor comments. PTAL
…ue to unexpected message length or bad continuation marker
…ue to unexpected message length or bad continuation marker
Contributor
Author
|
Thanks @luoyuxia , pushed new changes based on your recommendations. I've attempted running Integ test but couldn't. Might need to sync with you on how to do that. |
luoyuxia
approved these changes
Dec 20, 2025
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@leekeiabstraction Thanks for the pr. LGTM.
I append a small commit to fix ci. Merging....
Btw, you can run
cargo fmt
cargo clippy --all-targets --fix --allow-dirty --allow-staged
to make ci happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #72
#72