fix: update RocksdbClient to use getDeclaredConstructor for options instantiation #749
Open
SYaoJun wants to merge 1 commit intoapache:masterfrom
Open
fix: update RocksdbClient to use getDeclaredConstructor for options instantiation #749SYaoJun wants to merge 1 commit intoapache:masterfrom
SYaoJun wants to merge 1 commit intoapache:masterfrom
Conversation
…nstantiation and replace deprecated KnnVectorField with KnnFloatVectorField in GraphVectorIndex
Leomrlin
reviewed
Mar 2, 2026
Contributor
Leomrlin
left a comment
Leomrlin
left a comment
There was a problem hiding this comment.
I'm not an expert on these changes, just shared a few comments. Could @tanghaodong25 please review this PR? He originally developed and submitted this part of the code, so he might have more thorough insights.
| LOGGER.info("rocksdb optionClass {}", optionClass); | ||
| try { | ||
| this.rocksDBOptions = (IRocksDBOptions) Class.forName(optionClass).newInstance(); | ||
| this.rocksDBOptions = (IRocksDBOptions) Class.forName(optionClass).getDeclaredConstructor().newInstance(); |
Contributor
There was a problem hiding this comment.
Do all implementation classes of optionClass have a no-argument constructor?
If some classes do not have a no-argument constructor, will getDeclaredConstructor() throw an exception?
| TopDocs topDocs = searcher.search(knnQuery, topK); | ||
|
|
||
| Document firstDoc = searcher.doc(topDocs.scoreDocs[0].doc); | ||
| Document firstDoc = searcher.storedFields().document(topDocs.scoreDocs[0].doc); |
Contributor
There was a problem hiding this comment.
What are the version requirements for Lucene regarding the storedFields() method? Does this change affect performance (by adding an extra method call)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update some the deprecated methods to use new methods.
What changes were proposed in this pull request?
How was this PR tested?